<html>
<head><meta charset="utf-8"><title>Should we really dismiss approvals? · t-compiler/wg-rustc-dev-guide · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/index.html">t-compiler/wg-rustc-dev-guide</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should.20we.20really.20dismiss.20approvals.3F.html">Should we really dismiss approvals?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="194621555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should%20we%20really%20dismiss%20approvals%3F/near/194621555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should.20we.20really.20dismiss.20approvals.3F.html#194621555">(Apr 19 2020 at 22:49)</a>:</h4>
<p>We dismiss approvals on PRs of rustc-dev-guide by branch protection. But I'm not sure if it's useful here, for example, it's painful when we fix just a typo. do we really need this protection?</p>



<a name="194621899"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should%20we%20really%20dismiss%20approvals%3F/near/194621899" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should.20we.20really.20dismiss.20approvals.3F.html#194621899">(Apr 19 2020 at 22:58)</a>:</h4>
<p>Ah, I had forgotten that was a setting we could change</p>



<a name="194621902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should%20we%20really%20dismiss%20approvals%3F/near/194621902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should.20we.20really.20dismiss.20approvals.3F.html#194621902">(Apr 19 2020 at 22:58)</a>:</h4>
<p>I just disabled it (though I can reenable it if people feel we should or if we see a high rate of accidents)</p>



<a name="194621933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should%20we%20really%20dismiss%20approvals%3F/near/194621933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should.20we.20really.20dismiss.20approvals.3F.html#194621933">(Apr 19 2020 at 22:59)</a>:</h4>
<p>Thanks!</p>



<a name="194630452"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should%20we%20really%20dismiss%20approvals%3F/near/194630452" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tshepang Lekhonkhobe <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should.20we.20really.20dismiss.20approvals.3F.html#194630452">(Apr 20 2020 at 03:34)</a>:</h4>
<p>what does "dismiss approvals" mean</p>



<a name="194744369"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should%20we%20really%20dismiss%20approvals%3F/near/194744369" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/Should.20we.20really.20dismiss.20approvals.3F.html#194744369">(Apr 20 2020 at 23:08)</a>:</h4>
<p><span class="user-mention" data-user-id="119529">@Tshepang Lekhonkhobe</span> on github, if you Approve the PR and then I push again, it "dismisses" the approval, meaning that you have to re-approve before it can be merged. Disabling that means that the author can push again without needing re-approval.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>